Add barbosshack prefix patch

This commit is contained in:
minish 2025-11-04 16:55:11 -05:00
parent be22a3940d
commit eec42222af
Signed by: min
SSH Key Fingerprint: SHA256:mf+pUTmK92Y57BuCjlkBdd82LqztTfDCQIUp0fCKABc
5 changed files with 105 additions and 0 deletions

View File

@ -57,6 +57,10 @@ fips = []
# `BORING_BSSL{,_FIPS}_SOURCE_PATH`. # `BORING_BSSL{,_FIPS}_SOURCE_PATH`.
underscore-wildcards = [] underscore-wildcards = []
# Add a prefix to all symbols in libcrypto and libssl to prevent conflicts
# with other OpenSSL or BoringSSL versions that might be linked in the same process.
prefix-symbols = []
[build-dependencies] [build-dependencies]
bindgen = { workspace = true } bindgen = { workspace = true }
cmake = { workspace = true } cmake = { workspace = true }

View File

@ -18,6 +18,7 @@ pub(crate) struct Features {
pub(crate) fips: bool, pub(crate) fips: bool,
pub(crate) rpk: bool, pub(crate) rpk: bool,
pub(crate) underscore_wildcards: bool, pub(crate) underscore_wildcards: bool,
pub(crate) prefix_symbols: bool,
} }
pub(crate) struct Env { pub(crate) struct Env {
@ -105,11 +106,13 @@ impl Features {
let fips = env::var_os("CARGO_FEATURE_FIPS").is_some(); let fips = env::var_os("CARGO_FEATURE_FIPS").is_some();
let rpk = env::var_os("CARGO_FEATURE_RPK").is_some(); let rpk = env::var_os("CARGO_FEATURE_RPK").is_some();
let underscore_wildcards = env::var_os("CARGO_FEATURE_UNDERSCORE_WILDCARDS").is_some(); let underscore_wildcards = env::var_os("CARGO_FEATURE_UNDERSCORE_WILDCARDS").is_some();
let prefix_symbols = env::var_os("CARGO_FEATURE_PREFIX_SYMBOLS").is_some();
Self { Self {
fips, fips,
rpk, rpk,
underscore_wildcards, underscore_wildcards,
prefix_symbols,
} }
} }

View File

@ -9,8 +9,10 @@ use std::process::{Command, Output};
use std::sync::OnceLock; use std::sync::OnceLock;
use crate::config::Config; use crate::config::Config;
use crate::prefix::{prefix_symbols, PrefixCallback};
mod config; mod config;
mod prefix;
fn should_use_cmake_cross_compilation(config: &Config) -> bool { fn should_use_cmake_cross_compilation(config: &Config) -> bool {
if config.host == config.target { if config.host == config.target {
@ -544,6 +546,10 @@ fn built_boring_source_path(config: &Config) -> &PathBuf {
.define("FIPS", "1"); .define("FIPS", "1");
} }
if config.features.prefix_symbols {
cfg.define("CMAKE_POSITION_INDEPENDENT_CODE", "ON");
}
cfg.build_target("ssl").build(); cfg.build_target("ssl").build();
cfg.build_target("crypto").build() cfg.build_target("crypto").build()
}) })
@ -571,6 +577,9 @@ fn main() {
if !config.env.docs_rs { if !config.env.docs_rs {
emit_link_directives(&config); emit_link_directives(&config);
} }
if config.features.prefix_symbols {
prefix_symbols(&config);
}
generate_bindings(&config); generate_bindings(&config);
} }
@ -665,6 +674,10 @@ fn generate_bindings(config: &Config) {
.clang_arg(sysroot.display().to_string()); .clang_arg(sysroot.display().to_string());
} }
if config.features.prefix_symbols {
builder = builder.parse_callbacks(Box::new(PrefixCallback));
}
let headers = [ let headers = [
"aes.h", "aes.h",
"asn1_mac.h", "asn1_mac.h",

View File

@ -0,0 +1,81 @@
use crate::{config::Config, pick_best_android_ndk_toolchain, run_command};
use std::{fs, io::Write, path::PathBuf, process::Command};
// The prefix to add to all symbols
// RBSSL = Rust BoringSSL, chosen arbitrarily to avoid collisions with other projects
const PREFIX: &str = "RBSSL";
// Callback to add a `link_name` macro with the prefix to all generated bindings
#[derive(Debug)]
pub struct PrefixCallback;
impl bindgen::callbacks::ParseCallbacks for PrefixCallback {
fn generated_link_name_override(
&self,
item_info: bindgen::callbacks::ItemInfo<'_>,
) -> Option<String> {
Some(format!("{PREFIX}_{}", item_info.name))
}
}
fn android_toolchain(config: &Config) -> PathBuf {
let mut android_bin_path = config
.env
.android_ndk_home
.clone()
.expect("Please set ANDROID_NDK_HOME for Android build");
android_bin_path.extend(["toolchains", "llvm", "prebuilt"]);
android_bin_path.push(pick_best_android_ndk_toolchain(&android_bin_path).unwrap());
android_bin_path.push("bin");
android_bin_path
}
pub fn prefix_symbols(config: &Config) {
// List static libraries to prefix symbols in
let static_libs: Vec<PathBuf> = [
config.out_dir.join("build"),
config.out_dir.join("build").join("ssl"),
config.out_dir.join("build").join("crypto"),
]
.iter()
.flat_map(|dir| {
["libssl.a", "libcrypto.a"]
.into_iter()
.map(move |file| PathBuf::from(dir).join(file))
})
.filter(|p| p.exists())
.collect();
// Use `nm` to list symbols in these static libraries
let nm = match &*config.target_os {
"android" => android_toolchain(config).join("llvm-nm"),
_ => PathBuf::from("nm"),
};
let out = run_command(Command::new(nm).args(&static_libs)).unwrap();
let mut redefine_syms: Vec<String> = String::from_utf8_lossy(&out.stdout)
.lines()
.filter(|l| {
[" T ", " D ", " B ", " C ", " R ", " W "]
.iter()
.any(|s| l.contains(s))
})
.filter_map(|l| l.split_whitespace().nth(2).map(|s| s.to_string()))
.filter(|l| !l.starts_with("_"))
.map(|l| format!("{l} {PREFIX}_{l}"))
.collect();
redefine_syms.sort();
redefine_syms.dedup();
let redefine_syms_path = config.out_dir.join("redefine_syms.txt");
let mut f = fs::File::create(&redefine_syms_path).unwrap();
for sym in &redefine_syms {
writeln!(f, "{sym}").unwrap();
}
f.flush().unwrap();
// Use `objcopy` to prefix symbols in these static libraries
let objcopy = match &*config.target_os {
"android" => android_toolchain(config).join("llvm-objcopy"),
_ => PathBuf::from("objcopy"),
};
for static_lib in &static_libs {
run_command(
Command::new(&objcopy)
.arg(format!("--redefine-syms={}", redefine_syms_path.display()))
.arg(static_lib),
)
.unwrap();
}
}

View File

@ -32,6 +32,10 @@ legacy-compat-deprecated = []
# `BORING_BSSL{,_FIPS}_ASSUME_PATCHED`. # `BORING_BSSL{,_FIPS}_ASSUME_PATCHED`.
underscore-wildcards = ["boring-sys/underscore-wildcards"] underscore-wildcards = ["boring-sys/underscore-wildcards"]
# Add a prefix to all symbols in libcrypto and libssl to prevent conflicts
# with other OpenSSL or BoringSSL versions that might be linked in the same process.
prefix-symbols = ["boring-sys/prefix-symbols"]
[dependencies] [dependencies]
bitflags = { workspace = true } bitflags = { workspace = true }
foreign-types = { workspace = true } foreign-types = { workspace = true }