min
/
lanzaboote
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tool: avoid creating unbootable system 

lzbt currently happily nukes all boot entries, if it can't parse any
bootspecs. With the upcoming incompatible bootspec change, this might
be a problem that's worth avoiding. :)

I changed lzbt to fail hard in case, it can't generate any boot
items.
This commit is contained in:
Julian Stecklina 2023-04-22 16:58:45 +02:00
parent 385eced09d
commit be458e3385
1 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
rust/tool/src/install.rs
View File

@ -4,7 +4,7 @@ use std::os::unix::prelude::PermissionsExt;
use std::path::{Path, PathBuf};
use std::process::Command;
use anyhow::{Context, Result};
use anyhow::{anyhow, Context, Result};
use nix::unistd::sync;
use tempfile::TempDir;
@ -163,24 +163,31 @@ impl Installer {
where
F: FnMut(&mut Self, &Generation, &mut GenerationArtifacts) -> Result<()>,
{
for link in links {
let generation_result = Generation::from_link(link)
.with_context(|| format!("Failed to build generation from link: {link:?}"));
let generations = links
.iter()
.filter_map(|link| {
let generation_result = Generation::from_link(link)
.with_context(|| format!("Failed to build generation from link: {link:?}"));
// Ignore failing to read a generation so that old malformed generations do not stop
// lzbt from working.
let generation = match generation_result {
Ok(generation) => generation,
Err(e) => {
// Ignore failing to read a generation so that old malformed generations do not stop
// lzbt from working.
if let Err(e) = &generation_result {
log::debug!(
"Ignoring generation {} because it's malformed.",
"Ignoring generation {} because it's malformed: {e:#}",
link.version
);
log::debug!("{e:#}");
continue;
}
};
generation_result.ok()
})
.collect::<Vec<Generation>>();
if generations.is_empty() {
// We can't continue, because we would remove all boot entries, if we did.
return Err(anyhow!("No bootable generations found! Aborting to avoid unbootable system. Please check for Lanzaboote updates!"));
}
for generation in generations {
build_generation_artifacts(self, &generation, generation_artifacts)
.context("Failed to build generation artifacts.")?;
@ -191,6 +198,7 @@ impl Installer {
.context("Failed to build generation artifacts for specialisation.")?;
}
}
Ok(())
}