min
/
boring2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Swap order of linking ssl/crypto 

GNU linkers will sometimes aggressively try to strip objects and archives from a
linker command line in a left-to-right fashion. When a linker hits an object
file that doesn't satisfy any unresolved symbols, it will discard the object and
not re-visit it. This means that currently if symbols are depended upon in
libssl then some of the dependencies of libssl (in libcrypto) may have already
been stripped, causing a link error.

By swapping the order of what's linked it reflects the natural flow of
dependencies and the linker should figure everything out for us.
This commit is contained in:
Alex Crichton 2015-09-01 11:12:22 -07:00
parent e28b73e1f6
commit bf16c19f31
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openssl-sys/build.rs
View File

@ -36,12 +36,12 @@ fn main() {
Some(ref v) => v.split(":").collect(), Some(ref v) => v.split(":").collect(),
None => if target.contains("windows") { None => if target.contains("windows") {
if get_mingw_in_path().is_some() && lib_dir.is_none() && include_dir.is_none() { if get_mingw_in_path().is_some() && lib_dir.is_none() && include_dir.is_none() {
vec!("eay32", "ssleay32") vec!["ssleay32", "eay32"]
} else { } else {
vec!("eay32", "ssl32") vec!["ssl32", "eay32"]
} }
} else { } else {
vec!("crypto", "ssl") vec!["ssl", "crypto"]
} }
}; };