diff --git a/boring/src/x509/verify.rs b/boring/src/x509/verify.rs index 933fbfe4..1968e4db 100644 --- a/boring/src/x509/verify.rs +++ b/boring/src/x509/verify.rs @@ -1,15 +1,16 @@ use crate::ffi; -use foreign_types::ForeignTypeRef; -use libc::{c_uint, c_ulong}; +use foreign_types::{ForeignType, ForeignTypeRef}; +use libc::{c_int, c_uint, c_ulong, time_t}; use std::net::IpAddr; use openssl_macros::corresponds; -use crate::cvt; use crate::error::ErrorStack; +use crate::{cvt, cvt_p}; bitflags! { /// Flags used to check an `X509` certificate. #[derive(Debug, PartialEq, Eq, Clone, Copy, PartialOrd, Ord, Hash)] + #[repr(transparent)] pub struct X509CheckFlags: c_uint { const ALWAYS_CHECK_SUBJECT = ffi::X509_CHECK_FLAG_ALWAYS_CHECK_SUBJECT as _; const NO_WILDCARDS = ffi::X509_CHECK_FLAG_NO_WILDCARDS as _; @@ -25,11 +26,33 @@ bitflags! { } } +#[doc(hidden)] +#[deprecated(note = "X509Flags renamed to X509VerifyFlags")] +pub use X509VerifyFlags as X509Flags; + bitflags! { /// Flags used to check an `X509` certificate. #[derive(Debug, PartialEq, Eq, Clone, Copy, PartialOrd, Ord, Hash)] - pub struct X509Flags: c_ulong { + #[repr(transparent)] + pub struct X509VerifyFlags: c_ulong { + const CB_ISSUER_CHECK = ffi::X509_V_FLAG_CB_ISSUER_CHECK as _; + const USE_CHECK_TIME = ffi::X509_V_FLAG_USE_CHECK_TIME as _; + const CRL_CHECK = ffi::X509_V_FLAG_CRL_CHECK as _; + const CRL_CHECK_ALL = ffi::X509_V_FLAG_CRL_CHECK_ALL as _; + const IGNORE_CRITICAL = ffi::X509_V_FLAG_IGNORE_CRITICAL as _; + const X509_STRICT = ffi::X509_V_FLAG_X509_STRICT as _; + const ALLOW_PROXY_CERTS = ffi::X509_V_FLAG_ALLOW_PROXY_CERTS as _; + const POLICY_CHECK = ffi::X509_V_FLAG_POLICY_CHECK as _; + const EXPLICIT_POLICY = ffi::X509_V_FLAG_EXPLICIT_POLICY as _; + const INHIBIT_ANY = ffi::X509_V_FLAG_INHIBIT_ANY as _; + const INHIBIT_MAP = ffi::X509_V_FLAG_INHIBIT_MAP as _; + const NOTIFY_POLICY = ffi::X509_V_FLAG_NOTIFY_POLICY as _; + const EXTENDED_CRL_SUPPORT = ffi::X509_V_FLAG_EXTENDED_CRL_SUPPORT as _; + const USE_DELTAS = ffi::X509_V_FLAG_USE_DELTAS as _; + const CHECK_SS_SIGNATURE = ffi::X509_V_FLAG_CHECK_SS_SIGNATURE as _; const TRUSTED_FIRST = ffi::X509_V_FLAG_TRUSTED_FIRST as _; + const PARTIAL_CHAIN = ffi::X509_V_FLAG_PARTIAL_CHAIN as _; + const NO_ALT_CHAINS = ffi::X509_V_FLAG_NO_ALT_CHAINS as _; } } @@ -41,30 +64,32 @@ foreign_type_and_impl_send_sync! { pub struct X509VerifyParam; } -impl X509VerifyParamRef { - /// Set flags. - /// - /// This corresponds to [`X509_VERIFY_PARAM_set_flags`]. - /// - /// [`X509_VERIFY_PARAM_set_flags`]: https://www.openssl.org/docs/man3.2/man3/X509_VERIFY_PARAM_set_flags.html - #[corresponds(X509_VERIFY_PARAM_set_flags)] - pub fn set_flags(&mut self, flags: X509Flags) { +impl X509VerifyParam { + /// Create an X509VerifyParam + #[corresponds(X509_VERIFY_PARAM_new)] + pub fn new() -> Result { unsafe { - ffi::X509_VERIFY_PARAM_set_flags(self.as_ptr(), flags.bits()); + ffi::init(); + let handle = cvt_p(ffi::X509_VERIFY_PARAM_new())?; + Ok(Self::from_ptr(handle)) + } + } +} + +impl X509VerifyParamRef { + /// Set verification flags. + #[corresponds(X509_VERIFY_PARAM_set_flags)] + pub fn set_flags(&mut self, flags: X509VerifyFlags) { + unsafe { + cvt(ffi::X509_VERIFY_PARAM_set_flags(self.as_ptr(), flags.bits())).unwrap(); } } - /// Clear flags. - /// - /// Useful to clear out default flags, such as `X509Flags::TRUSTED_FIRST` when the fips feature is off. - /// - /// This corresponds to [`X509_VERIFY_PARAM_clear_flags`]. - /// - /// [`X509_VERIFY_PARAM_set_flags`]: https://www.openssl.org/docs/man3.2/man3/X509_VERIFY_PARAM_set_flags.html + /// Clear verification flags. #[corresponds(X509_VERIFY_PARAM_clear_flags)] - pub fn clear_flags(&mut self, flags: X509Flags) { + pub fn clear_flags(&mut self, flags: X509VerifyFlags) { unsafe { - ffi::X509_VERIFY_PARAM_clear_flags(self.as_ptr(), flags.bits()); + cvt(ffi::X509_VERIFY_PARAM_clear_flags(self.as_ptr(), flags.bits())).unwrap(); } } @@ -77,19 +102,43 @@ impl X509VerifyParamRef { } } + /// Gets verification flags. + #[corresponds(X509_VERIFY_PARAM_get_flags)] + pub fn flags(&self) -> X509VerifyFlags { + let bits = unsafe { ffi::X509_VERIFY_PARAM_get_flags(self.as_ptr()) }; + X509VerifyFlags::from_bits_retain(bits) + } + /// Set the expected DNS hostname. #[corresponds(X509_VERIFY_PARAM_set1_host)] pub fn set_host(&mut self, host: &str) -> Result<(), ErrorStack> { unsafe { + // len == 0 means "run strlen" :( + let raw_host = if host.is_empty() { "\0" } else { host }; cvt(ffi::X509_VERIFY_PARAM_set1_host( self.as_ptr(), - host.as_ptr() as *const _, + raw_host.as_ptr() as *const _, host.len(), )) .map(|_| ()) } } + /// Set the expected email address. + #[corresponds(X509_VERIFY_PARAM_set1_email)] + pub fn set_email(&mut self, email: &str) -> Result<(), ErrorStack> { + unsafe { + // len == 0 means "run strlen" :( + let raw_email = if email.is_empty() { "\0" } else { email }; + cvt(ffi::X509_VERIFY_PARAM_set1_email( + self.as_ptr(), + raw_email.as_ptr() as *const _, + email.len(), + )) + .map(|_| ()) + } + } + /// Set the expected IPv4 or IPv6 address. #[corresponds(X509_VERIFY_PARAM_set1_ip)] pub fn set_ip(&mut self, ip: IpAddr) -> Result<(), ErrorStack> { @@ -113,4 +162,16 @@ impl X509VerifyParamRef { .map(|_| ()) } } + + /// Set the verification time, where time is of type time_t, traditionaly defined as seconds since the epoch + #[corresponds(X509_VERIFY_PARAM_set_time)] + pub fn set_time(&mut self, time: time_t) { + unsafe { ffi::X509_VERIFY_PARAM_set_time(self.as_ptr(), time) } + } + + /// Set the verification depth + #[corresponds(X509_VERIFY_PARAM_set_depth)] + pub fn set_depth(&mut self, depth: c_int) { + unsafe { ffi::X509_VERIFY_PARAM_set_depth(self.as_ptr(), depth) } + } }