From 8ad1e5565b530832a2cf45f3994393c9a77236f0 Mon Sep 17 00:00:00 2001 From: Steven Fackler Date: Sat, 5 Nov 2016 18:49:09 -0700 Subject: [PATCH] Remove set_rsa PKey is reference counted so allowing mutation is unsound --- openssl/src/pkey.rs | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/openssl/src/pkey.rs b/openssl/src/pkey.rs index a1b90a86..a1ebd695 100644 --- a/openssl/src/pkey.rs +++ b/openssl/src/pkey.rs @@ -6,7 +6,7 @@ use ffi; use {cvt, cvt_p}; use bio::{MemBio, MemBioSlice}; use dsa::Dsa; -use rsa::{Rsa, RsaRef}; +use rsa::Rsa; use error::ErrorStack; use util::{CallbackState, invoke_passwd_cb}; use types::{OpenSslType, OpenSslTypeRef}; @@ -146,16 +146,6 @@ impl PKey { Ok(PKey::from_ptr(evp)) } } - - /// Assign an RSA key to this pkey. - pub fn set_rsa(&mut self, rsa: &RsaRef) -> Result<(), ErrorStack> { - unsafe { - // this needs to be a reference as the set1_RSA ups the reference count - let rsa_ptr = rsa.as_ptr(); - try!(cvt(ffi::EVP_PKEY_set1_RSA(self.0, rsa_ptr))); - Ok(()) - } - } } #[cfg(test)]