Add barbosshack prefix patch
This commit is contained in:
parent
cd2c47eb5b
commit
60ab50e89e
|
|
@ -86,6 +86,10 @@ pq-experimental = []
|
|||
# those for `pq-experimental` feature apply.
|
||||
underscore-wildcards = []
|
||||
|
||||
# Add a prefix to all symbols in libcrypto and libssl to prevent conflicts
|
||||
# with other OpenSSL or BoringSSL versions that might be linked in the same process.
|
||||
prefix-symbols = []
|
||||
|
||||
[build-dependencies]
|
||||
autocfg = { workspace = true }
|
||||
bindgen = { workspace = true }
|
||||
|
|
|
|||
|
|
@ -21,6 +21,7 @@ pub(crate) struct Features {
|
|||
pub(crate) pq_experimental: bool,
|
||||
pub(crate) rpk: bool,
|
||||
pub(crate) underscore_wildcards: bool,
|
||||
pub(crate) prefix_symbols: bool,
|
||||
}
|
||||
|
||||
pub(crate) struct Env {
|
||||
|
|
@ -125,6 +126,7 @@ impl Features {
|
|||
let pq_experimental = env::var_os("CARGO_FEATURE_PQ_EXPERIMENTAL").is_some();
|
||||
let rpk = env::var_os("CARGO_FEATURE_RPK").is_some();
|
||||
let underscore_wildcards = env::var_os("CARGO_FEATURE_UNDERSCORE_WILDCARDS").is_some();
|
||||
let prefix_symbols = env::var_os("CARGO_FEATURE_PREFIX_SYMBOLS").is_some();
|
||||
|
||||
Self {
|
||||
fips,
|
||||
|
|
@ -133,6 +135,7 @@ impl Features {
|
|||
pq_experimental,
|
||||
rpk,
|
||||
underscore_wildcards,
|
||||
prefix_symbols,
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -9,8 +9,10 @@ use std::process::{Command, Output};
|
|||
use std::sync::OnceLock;
|
||||
|
||||
use crate::config::Config;
|
||||
use crate::prefix::{prefix_symbols, PrefixCallback};
|
||||
|
||||
mod config;
|
||||
mod prefix;
|
||||
|
||||
fn should_use_cmake_cross_compilation(config: &Config) -> bool {
|
||||
if config.host == config.target {
|
||||
|
|
@ -592,6 +594,10 @@ fn built_boring_source_path(config: &Config) -> &PathBuf {
|
|||
cfg.define("FIPS", "1");
|
||||
}
|
||||
|
||||
if config.features.prefix_symbols {
|
||||
cfg.define("CMAKE_POSITION_INDEPENDENT_CODE", "ON");
|
||||
}
|
||||
|
||||
cfg.build_target("ssl").build();
|
||||
cfg.build_target("crypto").build()
|
||||
})
|
||||
|
|
@ -663,6 +669,9 @@ fn main() {
|
|||
if !config.env.docs_rs {
|
||||
emit_link_directives(&config);
|
||||
}
|
||||
if config.features.prefix_symbols {
|
||||
prefix_symbols(&config);
|
||||
}
|
||||
generate_bindings(&config);
|
||||
}
|
||||
|
||||
|
|
@ -765,6 +774,10 @@ fn generate_bindings(config: &Config) {
|
|||
.clang_arg(sysroot.display().to_string());
|
||||
}
|
||||
|
||||
if config.features.prefix_symbols {
|
||||
builder = builder.parse_callbacks(Box::new(PrefixCallback));
|
||||
}
|
||||
|
||||
let headers = [
|
||||
"aes.h",
|
||||
"asn1_mac.h",
|
||||
|
|
|
|||
|
|
@ -0,0 +1,89 @@
|
|||
use crate::{config::Config, pick_best_android_ndk_toolchain, run_command};
|
||||
use std::{fs, io::Write, path::PathBuf, process::Command};
|
||||
|
||||
// The prefix to add to all symbols
|
||||
// RBSSL = Rust BoringSSL, chosen arbitrarily to avoid collisions with other projects
|
||||
const PREFIX: &str = "RBSSL";
|
||||
|
||||
// Callback to add a `link_name` macro with the prefix to all generated bindings
|
||||
#[derive(Debug)]
|
||||
pub struct PrefixCallback;
|
||||
|
||||
impl bindgen::callbacks::ParseCallbacks for PrefixCallback {
|
||||
fn generated_link_name_override(
|
||||
&self,
|
||||
item_info: bindgen::callbacks::ItemInfo<'_>,
|
||||
) -> Option<String> {
|
||||
Some(format!("{PREFIX}_{}", item_info.name))
|
||||
}
|
||||
}
|
||||
|
||||
fn android_toolchain(config: &Config) -> PathBuf {
|
||||
let mut android_bin_path = config
|
||||
.env
|
||||
.android_ndk_home
|
||||
.clone()
|
||||
.expect("Please set ANDROID_NDK_HOME for Android build");
|
||||
android_bin_path.extend(["toolchains", "llvm", "prebuilt"]);
|
||||
android_bin_path.push(pick_best_android_ndk_toolchain(&android_bin_path).unwrap());
|
||||
android_bin_path.push("bin");
|
||||
android_bin_path
|
||||
}
|
||||
|
||||
pub fn prefix_symbols(config: &Config) {
|
||||
// List static libraries to prefix symbols in
|
||||
let static_libs: Vec<PathBuf> = [
|
||||
config.out_dir.join("build"),
|
||||
config.out_dir.join("build").join("ssl"),
|
||||
config.out_dir.join("build").join("crypto"),
|
||||
]
|
||||
.iter()
|
||||
.flat_map(|dir| {
|
||||
["libssl.a", "libcrypto.a"]
|
||||
.into_iter()
|
||||
.map(move |file| PathBuf::from(dir).join(file))
|
||||
})
|
||||
.filter(|p| p.exists())
|
||||
.collect();
|
||||
|
||||
// Use `nm` to list symbols in these static libraries
|
||||
let nm = match &*config.target_os {
|
||||
"android" => android_toolchain(config).join("llvm-nm"),
|
||||
_ => PathBuf::from("nm"),
|
||||
};
|
||||
let out = run_command(Command::new(nm).args(&static_libs)).unwrap();
|
||||
let mut redefine_syms: Vec<String> = String::from_utf8_lossy(&out.stdout)
|
||||
.lines()
|
||||
.filter(|l| {
|
||||
[" T ", " D ", " B ", " C ", " R ", " W "]
|
||||
.iter()
|
||||
.any(|s| l.contains(s))
|
||||
})
|
||||
.filter_map(|l| l.split_whitespace().nth(2).map(|s| s.to_string()))
|
||||
.filter(|l| !l.starts_with("_"))
|
||||
.map(|l| format!("{l} {PREFIX}_{l}"))
|
||||
.collect();
|
||||
redefine_syms.sort();
|
||||
redefine_syms.dedup();
|
||||
|
||||
let redefine_syms_path = config.out_dir.join("redefine_syms.txt");
|
||||
let mut f = fs::File::create(&redefine_syms_path).unwrap();
|
||||
for sym in &redefine_syms {
|
||||
writeln!(f, "{sym}").unwrap();
|
||||
}
|
||||
f.flush().unwrap();
|
||||
|
||||
// Use `objcopy` to prefix symbols in these static libraries
|
||||
let objcopy = match &*config.target_os {
|
||||
"android" => android_toolchain(config).join("llvm-objcopy"),
|
||||
_ => PathBuf::from("objcopy"),
|
||||
};
|
||||
for static_lib in &static_libs {
|
||||
run_command(
|
||||
Command::new(&objcopy)
|
||||
.arg(format!("--redefine-syms={}", redefine_syms_path.display()))
|
||||
.arg(static_lib),
|
||||
)
|
||||
.unwrap();
|
||||
}
|
||||
}
|
||||
|
|
@ -55,6 +55,10 @@ pq-experimental = ["boring-sys/pq-experimental"]
|
|||
# those for `pq-experimental` feature apply.
|
||||
underscore-wildcards = ["boring-sys/underscore-wildcards"]
|
||||
|
||||
# Add a prefix to all symbols in libcrypto and libssl to prevent conflicts
|
||||
# with other OpenSSL or BoringSSL versions that might be linked in the same process.
|
||||
prefix-symbols = ["boring-sys/prefix-symbols"]
|
||||
|
||||
# Controlling key exchange preferences at compile time
|
||||
|
||||
# Choose key exchange preferences at compile time. This prevents the user from
|
||||
|
|
|
|||
Loading…
Reference in New Issue