diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 28b62e97..49c1acfd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -54,7 +54,7 @@ jobs: with: path: target key: clippy-target-${{ runner.os }}-${{ steps.rust-version.outputs.version }}-${{ hashFiles('Cargo.lock') }} - - name: Run clippy clippy + - name: Run clippy run: cargo clippy --all --all-targets min-version: diff --git a/openssl/src/envelope.rs b/openssl/src/envelope.rs index 22a14117..bd4e1b43 100644 --- a/openssl/src/envelope.rs +++ b/openssl/src/envelope.rs @@ -92,6 +92,7 @@ impl Seal { } /// Returns the initialization vector, if the cipher uses one. + #[allow(clippy::option_as_ref_deref)] pub fn iv(&self) -> Option<&[u8]> { self.iv.as_ref().map(|v| &**v) } diff --git a/openssl/src/error.rs b/openssl/src/error.rs index c1ef043e..55567e2b 100644 --- a/openssl/src/error.rs +++ b/openssl/src/error.rs @@ -229,6 +229,7 @@ impl Error { } /// Returns additional data describing the error. + #[allow(clippy::option_as_ref_deref)] pub fn data(&self) -> Option<&str> { self.data.as_ref().map(|s| &**s) } diff --git a/openssl/src/stack.rs b/openssl/src/stack.rs index fc2eafae..d70be351 100644 --- a/openssl/src/stack.rs +++ b/openssl/src/stack.rs @@ -46,7 +46,7 @@ unsafe impl Sync for Stack {} impl Drop for Stack { fn drop(&mut self) { unsafe { - while let Some(_) = self.pop() {} + while self.pop().is_some() {} OPENSSL_sk_free(self.0 as *mut _); } }