From 04abc99fb2d7bd8ed1e05605379960c4aaf5e01d Mon Sep 17 00:00:00 2001 From: Rushil Mehra Date: Mon, 29 Jul 2024 10:45:26 -0700 Subject: [PATCH] Fix clippy lints re: docs indentation + unused feature --- boring/src/lib.rs | 14 +++++++------- boring/src/ssl/mod.rs | 8 ++++---- boring/src/ssl/test/mod.rs | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/boring/src/lib.rs b/boring/src/lib.rs index 423679f2..4d477a72 100644 --- a/boring/src/lib.rs +++ b/boring/src/lib.rs @@ -78,15 +78,15 @@ //! agreements: //! //! - `X25519Kyber768Draft00Old` is the same as `X25519Kyber768Draft00`, but under its old codepoint. -//! -`X25519Kyber512Draft00`. Similar to `X25519Kyber768Draft00`, but uses level 1 parameter set for -//! Kyber. Not recommended. It's useful to test whether the shorter ClientHello upsets fewer middle -//! boxes. +//! - `X25519Kyber512Draft00`. Similar to `X25519Kyber768Draft00`, but uses level 1 parameter set for +//! Kyber. Not recommended. It's useful to test whether the shorter ClientHello upsets fewer middle +//! boxes. //! - `P256Kyber768Draft00`. Similar again to `X25519Kyber768Draft00`, but uses P256 as classical -//! part. It uses a non-standard codepoint. Not recommended. +//! part. It uses a non-standard codepoint. Not recommended. //! - `IPDWing`. A preliminary version of -//! [X-Wing](https://datatracker.ietf.org/doc/draft-connolly-cfrg-xwing-kem/02/). -//! Similar to `X25519Kyber768Draft00Old`, but uses a newer (but not yet final) version of Kyber -//! called ML-KEM-ipd. Not recommended. +//! [X-Wing](https://datatracker.ietf.org/doc/draft-connolly-cfrg-xwing-kem/02/). +//! Similar to `X25519Kyber768Draft00Old`, but uses a newer (but not yet final) version of Kyber +//! called ML-KEM-ipd. Not recommended. //! //! Presently all these key agreements are deployed by Cloudflare, but we do not guarantee continued //! support for them. diff --git a/boring/src/ssl/mod.rs b/boring/src/ssl/mod.rs index 751daae7..e3fd5d1f 100644 --- a/boring/src/ssl/mod.rs +++ b/boring/src/ssl/mod.rs @@ -534,9 +534,9 @@ impl SelectCertError { /// Extension types, to be used with `ClientHello::get_extension`. /// -/// NOTE: The current implementation of `From` is unsound, as it's possible to create an ExtensionType -/// that is not defined by the impl. `From` will be deprecated in favor of `TryFrom` in the next -/// major bump of the library. +/// **WARNING**: The current implementation of `From` is unsound, as it's possible to create an +/// ExtensionType that is not defined by the impl. `From` will be deprecated in favor of `TryFrom` +/// in the next major bump of the library. #[derive(Debug, Copy, Clone, PartialEq, Eq)] pub struct ExtensionType(u16); @@ -645,7 +645,7 @@ impl fmt::Display for SslVersion { /// A signature verification algorithm. /// -/// NOTE: The current implementation of `From` is unsound, as it's possible to create an +/// **WARNING**: The current implementation of `From` is unsound, as it's possible to create an /// SslSignatureAlgorithm that is not defined by the impl. `From` will be deprecated in favor of /// `TryFrom` in the next major bump of the library. #[repr(transparent)] diff --git a/boring/src/ssl/test/mod.rs b/boring/src/ssl/test/mod.rs index f40cb7f4..4ed9af71 100644 --- a/boring/src/ssl/test/mod.rs +++ b/boring/src/ssl/test/mod.rs @@ -469,7 +469,7 @@ fn refcount_ssl_context() { #[test] #[cfg_attr(target_os = "windows", ignore)] -#[cfg_attr(all(target_os = "macos", feature = "vendored"), ignore)] +#[cfg_attr(all(target_os = "macos"), ignore)] fn default_verify_paths() { let mut ctx = SslContext::builder(SslMethod::tls()).unwrap(); ctx.set_default_verify_paths().unwrap();